RFR(T): 8222299: [TESTBUG] Docker tests should be excluded from hotspot_runtime group

Igor Ignatev igor.ignatyev at oracle.com
Thu Apr 11 01:13:19 UTC 2019


Should these test be filtered out using @requires?

— Igor

> On Apr 10, 2019, at 6:06 PM, mikhailo.seledtsov at oracle.com wrote:
> 
> Please review this small (trivial) change that excludes docker tests from hotspot_runtime. The rational for this change is that docker tests require specially configured environment (docker engine installed, test user being member of docker group, docker proxy or docker mirror repo configured). This may lead to unexpected errors when docker tests are ran as part of hotspot_runtime group in general environment(s).
> 
> 
> JBS: https://bugs.openjdk.java.net/browse/JDK-8222299
> 
> Change:
> 
> diff --git a/test/hotspot/jtreg/TEST.groups b/test/hotspot/jtreg/TEST.groups
> --- a/test/hotspot/jtreg/TEST.groups
> +++ b/test/hotspot/jtreg/TEST.groups
> @@ -44,7 +44,8 @@
>    -gc/nvdimm
> 
>  hotspot_runtime = \
> -  runtime
> +  runtime \
> +  -runtime/containers/docker
> 
>  hotspot_handshake = \
>    runtime/handshake
> 
> Testing:
> 
>   jtreg -l /ws/hg/jdk/jdk/work01/open/test/hotspot/jtreg/:hotspot_runtime
> 
>   jtreg -l /ws/hg/jdk/jdk/work01/open/test/hotspot/jtreg/:hotspot_runtime | grep docker
> 
> 
> Thank you,
> 
> Misha
> 



More information about the hotspot-runtime-dev mailing list