RFR(T): 8222299: [TESTBUG] Docker tests should be excluded from hotspot_runtime group

[mikhailo.seledtsov at oracle.com]

Hi Igor,

Thank you for taking a look.


On 4/10/19 6:13 PM, Igor Ignatev wrote:
> Should these test be filtered out using @requires?
Checking all the conditions for this via @requires will require building 
a test docker image (or at least downloading the base/FROM) image in 
evaluation of at-requires, which will be unacceptably long, especially 
given that @requires is evaluated each time one runs jtreg command for 
any test in hotspot.

Alternatively, if the current approach is undesirable, we can throw 
jtreg.Skipped exception if docker base image fails to download. Let me 
know if this is your preference.

Misha
>
> — Igor
>
>> On Apr 10, 2019, at 6:06 PM, mikhailo.seledtsov at oracle.com wrote:
>>
>> Please review this small (trivial) change that excludes docker tests from hotspot_runtime. The rational for this change is that docker tests require specially configured environment (docker engine installed, test user being member of docker group, docker proxy or docker mirror repo configured). This may lead to unexpected errors when docker tests are ran as part of hotspot_runtime group in general environment(s).
>>
>>
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8222299
>>
>> Change:
>>
>> diff --git a/test/hotspot/jtreg/TEST.groups b/test/hotspot/jtreg/TEST.groups
>> --- a/test/hotspot/jtreg/TEST.groups
>> +++ b/test/hotspot/jtreg/TEST.groups
>> @@ -44,7 +44,8 @@
>>     -gc/nvdimm
>>
>>   hotspot_runtime = \
>> -  runtime
>> +  runtime \
>> +  -runtime/containers/docker
>>
>>   hotspot_handshake = \
>>     runtime/handshake
>>
>> Testing:
>>
>>    jtreg -l /ws/hg/jdk/jdk/work01/open/test/hotspot/jtreg/:hotspot_runtime
>>
>>    jtreg -l /ws/hg/jdk/jdk/work01/open/test/hotspot/jtreg/:hotspot_runtime | grep docker
>>
>>
>> Thank you,
>>
>> Misha
>>