RFR (XS) 8222297: IRT_ENTRY/IRT_LEAF etc are the same as JRT

[Daniel D. Daugherty]

On 4/11/19 11:39 AM, coleen.phillimore at oracle.com wrote:
> Summary: Replace IRT entry points with JRT.
>
> Tested with hs tier1-3 and built zero.  And grepped from the right 
> level directory this time.
>
> open webrev at http://cr.openjdk.java.net/~coleenp/2019/8222297.01/webrev

src/hotspot/cpu/aarch64/interpreterRT_aarch64.cpp
     No comments.

src/hotspot/cpu/arm/interpreterRT_arm.cpp
     No comments.

src/hotspot/cpu/ppc/interpreterRT_ppc.cpp
     No comments.

src/hotspot/cpu/s390/interpreterRT_s390.cpp
     No comments.

src/hotspot/cpu/sparc/interpreterRT_sparc.cpp
     No comments.

src/hotspot/cpu/x86/interpreterRT_x86_32.cpp
     No comments.

src/hotspot/cpu/x86/interpreterRT_x86_64.cpp
     No comments.

src/hotspot/cpu/zero/cppInterpreter_zero.cpp
     No comments.

src/hotspot/cpu/zero/interpreterRT_zero.cpp
     No comments.

src/hotspot/share/interpreter/interpreterRuntime.cpp
src/hotspot/share/runtime/interfaceSupport.inline.hpp
     old L435: #define IRT_LEAF(result_type, header)
     old L438:     debug_only(NoSafepointVerifier __nspv(true);)
     new L432: #define JRT_LEAF(result_type, header)
     new L435:   debug_only(JRTLeafVerifier __jlv;)
         src/hotspot/share/runtime/interfaceSupport.cpp:

           JRTLeafVerifier::JRTLeafVerifier()
             : NoSafepointVerifier(true, 
JRTLeafVerifier::should_verify_GC())
           {
           }

         src/hotspot/share/runtime/safepointVerifiers.hpp:

           NoSafepointVerifier(bool activated = true, bool verifygc = 
true ) :
             NoGCVerifier(verifygc),
             _activated(activated) {

         IRT_LEAF creates a NoSafepointVerifier with first ctr param == true
         and the second ctr param == default true.

         JRT_LEAF creates a JRTLeafVerifier subclassed on 
NoSafepointVerifier
         with first ctr param == true and second ctr param based on
         JRTLeafVerifier::should_verify_GC() which can return either
         true or false depending on the calling thread's state. If the
         thread's state == _thread_in_Java, then the return == true.
         If the thread's state == _thread_in_native, then the return == 
false.

         As long as all the IRT_LEAF uses are thread state == 
_thread_in_Java
         then this is an equivalent change.

         I found these uses of IRT_LEAF:

           SharedRuntime::fixup_callers_callsite()
           InterpreterRuntime::bcp_to_di()
           InterpreterRuntime::verify_mdp()
           InterpreterRuntime::interpreter_contains()
           InterpreterRuntime::popframe_move_outgoing_args()
           InterpreterRuntime::trace_bytecode()

         I have not checked to see if these IRT_LEAF functions are
         ever called from thread state == _thread_in_native locations,
         but if they are, then we will no longer 'verifygc' with the
         JRT_LEAF switch.


src/hotspot/share/runtime/sharedRuntime.cpp
     No comments.


Your call on what to do about the difference that I found between
IRT_LEAF and JRT_LEAF. We could be losing a 'verifygc' check here,
but...

Dan


> bug link https://bugs.openjdk.java.net/browse/JDK-8222297
>
> Thanks,
> Coleen