RFR(S): JDK-8222299: [TESTBUG] move hotspot container tests to hotspot/containers
mikhailo.seledtsov at oracle.com
mikhailo.seledtsov at oracle.com
Fri Apr 12 01:59:55 UTC 2019
David, Jie, thank you for reviews.
Here is the webrev with update to the docs (html and .md):
http://cr.openjdk.java.net/~mseledtsov/8222299.01/
Thank you,
Misha
On 4/11/19 6:47 PM, mikhailo.seledtsov at oracle.com wrote:
> Thank you Jie,
>
> Good catch. I will update the docs.
>
>
> Misha
>
>
> On 4/11/19 5:57 PM, Jie Fu wrote:
>> Hi Misha,
>>
>> It might be better to update the test doc[1][2] together.
>> Thanks.
>>
>> Best regards,
>> Jie
>>
>> [1]
>> http://hg.openjdk.java.net/jdk/jdk/file/a2795025f417/doc/testing.md#l384
>> [2]
>> http://hg.openjdk.java.net/jdk/jdk/file/a2795025f417/doc/testing.md#l389
>>
>>
>> On 2019/4/12 上午6:46, mikhailo.seledtsov at oracle.com wrote:
>>> Please review this change that moves HotSpot container tests into
>>> their own directory under test/hotspot/jtreg and
>>> creates hotspot_containers test group. Since container tests require
>>> specially setup/configured environment, it is best to group them
>>> into their own group,
>>> so they could be executed in properly configured environment. The
>>> details of this change, such as new location were
>>> recommended by David and Igor during earlier public review for this
>>> issue (8222299: [TESTBUG] Docker tests should be excluded from
>>> hotspot_runtime group).
>>>
>>> Also, as part of this review, Igor recommended to use jtreg.skipped
>>> exception if docker image build fails, which I agreed to
>>> and implemented.
>>>
>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8222299
>>> Webrev: http://cr.openjdk.java.net/~mseledtsov/8222299.00/
>>> Testing:
>>> Ran the affected tests on a machine configured for Docker
>>> testing.
>>> Ran them two ways, via specifying the directory as well as by
>>> using a newly created group - PASS
>>>
>>>
>>> Thank you,
>>> Misha
>>>
>>
>
More information about the hotspot-runtime-dev
mailing list