RFR(s): 8222327: java_lang_Thread _thread_status_offset, remove pre 1.5 code paths

[David Holmes]

Hi Robbin,

On 16/04/2019 6:17 pm, Robbin Ehn wrote:
> Hi Claes and David,
> 
> Here is v2:
> http://cr.openjdk.java.net/~rehn/8222327/v2/

This is missing any check that the offsets are always initialized before 
use. Can you guarantee none of these will be used in such a case? If so 
asserts at least would be good.

   oop java_lang_Thread::park_blocker(oop java_thread) {
!   assert(JDK_Version::current().supports_thread_park_blocker(),
!          "Must support parkBlocker field");

This assert can be removed as can 
JDK_Version::supports_thread_park_blocker() and possibly other stuff, as 
they also represent pre-1.5 code paths.

Thanks,
David
-----

> Inc:
> http://cr.openjdk.java.net/~rehn/8222327/v2/inc/
> 
> Passed t1-2.
> 
> Thanks, Robbin
> 
> On 4/15/19 11:04 AM, Robbin Ehn wrote:
>> Hi all, please review.
>>
>> Removing some dead code.
>>
>> Code:
>> http://cr.openjdk.java.net/~rehn/8222327/webrev/
>> Issue:
>> https://bugs.openjdk.java.net/browse/JDK-8222327
>>
>> Passes t1-5.
>>
>> Thanks, Robbin