RFR(s): 8222327: java_lang_Thread _thread_status_offset, remove pre 1.5 code paths

[Robbin Ehn]

Hi David,

On 4/16/19 12:42 PM, David Holmes wrote:
> 
> I thought you were on a crusade to get rid of pre JDK 1.5 code ;-) Okay we can 
> leave this to another cleanup.

:)

> 
>>  From other mail:
>>  >If the offset is not initialized you will now crash (most likely) instead of 
>> >getting a zero etc. This would only be a potential issue during VM 
>> >initialization, and possibly only on initialization failures which makes this 
>> >very hard to test.
>>
>> But the other ones don't have assert so that is the case today.
> 
> So they could potentially both be wrong.
> 
> As it is this code is initialized via init_globals() before any Java Thread 
> object can be created, so there is no issue with access.

Good, thanks.

/Robbin

> 
> Thanks,
> David
> 
>> Thanks, Robbin
>>
>>
>>>
>>> Thanks,
>>> David
>>> -----
>>>
>>>> Inc:
>>>> http://cr.openjdk.java.net/~rehn/8222327/v2/inc/
>>>>
>>>> Passed t1-2.
>>>>
>>>> Thanks, Robbin
>>>>
>>>> On 4/15/19 11:04 AM, Robbin Ehn wrote:
>>>>> Hi all, please review.
>>>>>
>>>>> Removing some dead code.
>>>>>
>>>>> Code:
>>>>> http://cr.openjdk.java.net/~rehn/8222327/webrev/
>>>>> Issue:
>>>>> https://bugs.openjdk.java.net/browse/JDK-8222327
>>>>>
>>>>> Passes t1-5.
>>>>>
>>>>> Thanks, Robbin