RFR: 8222550: runtime/MemberName/MemberNameLeak.java times out

[David Holmes]

Hi Stefan,

On 17/04/2019 7:24 am, Stefan Karlsson wrote:
> Hi all,
> 
> Please review this patch to fix a timeout in the MemberNameLeak test.
> 
> https://cr.openjdk.java.net/~stefank/8222550/webrev.01/
> https://bugs.openjdk.java.net/browse/JDK-8222550
> 
> The test could fail if GCs happened during the setup phase when entries 
> for all generated methods were created. When this happened the code to 
> grow the table was triggered, which in turn cleaned out all so-far 
> created entries.  This put the table in a condition where the grow / 
> cleaning code didn't have to be triggered again. But the test still 
> waited for it to happen. This patch adds all MethodHandles to an 
> ArrayList, so that they are kept alive until it's time for them to be 
> cleaned out. While debugging this timeout I added some extra logging. 
> I've left it in the test in case we ever need to debug it again.

Fix seems reasonable. A couple of comments:

  119 
"-Xlog:membername+table=trace,gc+verify=debug,gc",
  120 
"-Xlog:membername+table=trace,gc+verify=debug,gc:gc.%p.log:time,utctime,uptime,pid,level,tags",

I'm assuming you only actually want line 120?

Is the log file copied across with the test artifacts in mach5? I'm 
assuming you're using the file for gc logging so that the normal test 
.jtr file is not inundated with excessive logging data.

Thanks,
David
-----

> Testing: tier1-3 and multiple tier1_runtime runs on osx where the 
> timeouts reproduced.
> 
> The patch is applied on top of the patch in:
> https://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2019-April/033820.html 
> 
> 
> Thanks,
> StefanK