RFR: 8222550: runtime/MemberName/MemberNameLeak.java times out

coleen.phillimore at oracle.com coleen.phillimore at oracle.com
Wed Apr 17 11:34:34 UTC 2019


This looks good to me.
Coleen

On 4/16/19 5:24 PM, Stefan Karlsson wrote:
> Hi all,
>
> Please review this patch to fix a timeout in the MemberNameLeak test.
>
> https://cr.openjdk.java.net/~stefank/8222550/webrev.01/
> https://bugs.openjdk.java.net/browse/JDK-8222550
>
> The test could fail if GCs happened during the setup phase when 
> entries for all generated methods were created. When this happened the 
> code to grow the table was triggered, which in turn cleaned out all 
> so-far created entries.  This put the table in a condition where the 
> grow / cleaning code didn't have to be triggered again. But the test 
> still waited for it to happen. This patch adds all MethodHandles to an 
> ArrayList, so that they are kept alive until it's time for them to be 
> cleaned out. While debugging this timeout I added some extra logging. 
> I've left it in the test in case we ever need to debug it again.
>
> Testing: tier1-3 and multiple tier1_runtime runs on osx where the 
> timeouts reproduced.
>
> The patch is applied on top of the patch in:
> https://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2019-April/033820.html 
>
>
> Thanks,
> StefanK



More information about the hotspot-runtime-dev mailing list