RFR (XS) 8222818: NMT summary could show the GC in use

[Kodewerk]

> On Apr 22, 2019, at 6:57 PM, Zhengyu Gu <zgu at redhat.com> wrote:
> 
> 
> 
> On 4/22/19 8:19 PM, David Holmes wrote:
>> Hi Eric,
>> On 23/04/2019 8:13 am, Eric Caspole wrote:
>>> Hi, could I have reviews and any opinions on this little change to show the GC name in the NMT output, as this helps us to more easily triage performance data.
>> The idea seems fine.
> 
>> For the implementation wouldn't it be simpler to do something like:
>> if (flag == mtGC) {
>>   out->print("%s - %s (", NMTUtil::flag_to_name(flag),
>>                           GCConfig::hs_err_name());
>> } else {
>>   out->print("-%26s (", NMTUtil::flag_to_name(flag));
>> }
> Yes, this is simpler.
> 
> I don't like where the name is placed, it screws up section alignments. I would prefer to place name inside parenthesis. e.g.
> 
> - GC (g1 gc reserved=379056KB, committed=93220KB)


- GC [g1 gc reserved=379056KB, committed=93220KB]

Is a format that is more inline with how other information is presented.

Kind regards,
Kirk