RFR(S): 8222295 more baseline cleanups from Async Monitor Deflation project

[coleen.phillimore at oracle.com]

http://cr.openjdk.java.net/~dcubed/8153224-webrev/4-for-jdk13.8222295/src/hotspot/share/oops/markOop.cpp.frames.html

   37     if (mon == NULL) {
   38       st->print("NULL (this should never be seen!)");
   39     } else {
40 st->print("{contentions=0x%08x,waiters=0x%08x"
   41                 ",recursions=" INTPTR_FORMAT ",owner=" INTPTR_FORMAT "}",
42 mon->contentions(), mon->waiters(), mon->recursions(),
   43                 p2i(mon->owner()));
   44     }


Following convention, it seems like this code should be in 
ObjectMonitor::print_on(outputStream* st) so markOop doesn't have to 
know objectMonitor fields/accessors.

Otherwise looks like a good self-contained cleanup to me.

Coleen

On 4/23/19 10:28 AM, Daniel D. Daugherty wrote:
> Greetings,
>
> I have a (S)mall patch extracted from the Async Monitor Deflation project
> that is ready for code review.
>
> Karen, a number of the changes here are from your code review comments
> to the parent bug:
>
>     JDK-8153224 Monitor deflation prolong safepoints
>     https://bugs.openjdk.java.net/browse/JDK-8153224
>
> The short version of what this patch is about:
>
>     More baseline cleanups to the ObjectMonitor subsystem.
>
> The details are in the bug report:
>
>     JDK-8222295 more baseline cleanups from Async Monitor Deflation 
> project
>     https://bugs.openjdk.java.net/browse/JDK-8222295
>
> Here's the webrev:
>
> http://cr.openjdk.java.net/~dcubed/8153224-webrev/4-for-jdk13.8222295/
>
> This patch along with the current patch for Async Monitor Deflation
> project have been through Mach5 tier[1-8] testing.
>
> I have been actively using the revised assert()'s and guarantee()'s with
> additional diagnostic info while debugging my port of the Async Monitor
> Deflation project code.
>
> Thanks, in advance, for any questions, comments or suggestions.
>
> Dan