RFR (T) 8229208: Remove Monitor::ClearMonitor

David Holmes david.holmes at oracle.com
Wed Aug 7 01:21:06 UTC 2019


Hi Coleen,

This cleanup looks good. I have a vague recollection that at one time 
ClearMonitor was used when monitors were recycled.

One additional nit I noticed:

  284   NOT_PRODUCT(_safepoint_check_required = safepoint_check_required;)

Isn't the NOT_PRODUCT redundant given this occurs in an #ifdef ASSERT block?

Thanks,
David

On 7/08/2019 9:26 am, coleen.phillimore at oracle.com wrote:
> Summary: And have Mutex constructor call Monitor constructor.
> 
> mach5 tier1 testing on all Oracle platforms in progress.
> 
> open webrev at http://cr.openjdk.java.net/~coleenp/2019/8229208.01/webrev
> bug link https://bugs.openjdk.java.net/browse/JDK-8229208
> 
> Thanks,
> Coleen


More information about the hotspot-runtime-dev mailing list