RFR(S) 8226645: [TESTBUG] some AppCDS tests relies on illegal reflective access

Calvin Cheung calvin.cheung at oracle.com
Wed Aug 14 00:32:47 UTC 2019


On 8/13/19 1:08 AM, Alan Bateman wrote:
> On 13/08/2019 08:56, David Holmes wrote:
>>
>> Sorry I don't quite see the connection between that test and the use 
>> of Utils.defineModifiedClass and the use of lookup(). ?? The type of 
>> classloader should not be relevant.
> Right, it's not relevant. Each of the tests just needs to get a Lookup 
> to a class in the target run-time package. In a few cases they will do 
> this with privateLookupIn.
>
Updated webrev:

     http://cr.openjdk.java.net/~ccheung/8226645/webrev.02/

Summary of changes:

- test case provides a lookup instance to Util.defineModifiedClass;

- implemented URLClassLoader.loadClass method in LoaderSegregation so no 
need to use Util.defineClassFromJAR;

- removed Util.defineClassFromJAR.

Testing:

      locally on linux-x64, mach5 tier1 - 3 (in progress), both with 
--illegal-access=deny

thanks,

Calvin



More information about the hotspot-runtime-dev mailing list