RFR(S) 8226645: [TESTBUG] some AppCDS tests relies on illegal reflective access

[Calvin Cheung]

Thanks, David!

Calvin

On 8/14/19 3:14 AM, David Holmes wrote:
> +1
>
> This is much clearer to me now.
>
> Thanks,
> David
>
> On 14/08/2019 4:32 pm, Alan Bateman wrote:
>> On 14/08/2019 01:32, Calvin Cheung wrote:
>>> Updated webrev:
>>>
>>>     http://cr.openjdk.java.net/~ccheung/8226645/webrev.02/
>>>
>>> Summary of changes:
>>>
>>> - test case provides a lookup instance to Util.defineModifiedClass;
>>>
>>> - implemented URLClassLoader.loadClass method in LoaderSegregation 
>>> so no need to use Util.defineClassFromJAR;
>>>
>>> - removed Util.defineClassFromJAR.
>>>
>> Can you fix the defineModifiedClass's method description? The comment 
>> talks about "peerClass" which I think is left over from a previous 
>> iteration.
>>
>> In LoaderSegregationTest it might be better to list 
>> LoaderSegregation$1 after its enclosing class.
>>
>> The rest looks good to me.
>>
>> -Alan.
>>