RFR (S) 8230003: Make Monitor inherit from Mutex

coleen.phillimore at oracle.com coleen.phillimore at oracle.com
Thu Aug 22 12:45:04 UTC 2019



On 8/22/19 2:59 AM, Robbin Ehn wrote:
> Hi Coleen,
>
> This comment is not a good one:
> 193 // PlatformMonitor extends PlatformMutex so this makes sense.
> This makes sense because a mutex is a subset of a monitor.

I removed it and some extra blank lines.
>
> Looks good. (minus some more monitor -> mutex naming as David pointed 
> out)

Fixed those too, please see webrevs in my reply to him.
Thanks,
Coleen

>
> Thanks, Robbin
>
> On 2019-08-22 04:52, coleen.phillimore at oracle.com wrote:
>> Summary: Reverse inheritance that makes more sense.
>>
>> See bug for more description.  Tested with hs-tier1-3 with 
>> linux-x64-debug and hs-tier1 on Oracle platforms.
>>
>> open webrev at 
>> http://cr.openjdk.java.net/~coleenp/2019/8230003.01/webrev
>> bug link https://bugs.openjdk.java.net/browse/JDK-8230003
>>
>> Thanks,
>> Coleen
>>
>>
>> *
>> *



More information about the hotspot-runtime-dev mailing list