RFR(S/L): 8230184 rename, whitespace, indent and comments changes in preparation for lock free Monitor lists

David Holmes david.holmes at oracle.com
Wed Aug 28 02:33:15 UTC 2019


Hi Dan,

On 28/08/2019 8:29 am, Daniel D. Daugherty wrote:
> Greetings,
> 
> This is my first set of JDK14 baseline cleanup changes extracted from the
> Async Monitor Deflation project (JDK-8153224).
> 
> This is an "S" review because it is conceptually Small. It is also an "L"
> review because it has a mind numbingly Large number of cleanup changes.
> Coleen, should appreciate this one since it takes care of a number of
> naming issues that she (and others) have wanted to see fixed for years.

Seems fine. Micro-commenting on individual changes or omissions would be 
counter-productive. :)

Cheers,
David
-----

> As usual, the bug report has a yacky description of what I'm cleaning up
> this round and why:
> 
>     JDK-8230184 rename, whitespace, indent and comments changes in 
> preparation
>                 for lock free Monitor lists
>     https://bugs.openjdk.java.net/browse/JDK-8230184
> 
> Here's the webrev URL:
> 
>      http://cr.openjdk.java.net/~dcubed/8230184-webrev/0_for_jdk14/
> 
> This webrev is relative to jdk-14+11.
> 
> This fix is included in my latest round of JDK-8153224 testing which
> included Mach5 Tier[1-8], my stress kit on Linux-X64 and Solaris-X64,
> my Inflate2 test running in parallel with Kitchensink8H on macOSX,
> Linux-X64 and Solaris-X64. I also ran the Inflate2 and Kitchensink8H
> combo in parallel on the jdk-14+11 baseline + this fix on macOSX,
> Linux-X64 and Solaris-X64. No regressions were observed in any of
> the testing.
> 
> Thanks, in advance, for any comments, suggestions or questions.
> 
> Dan


More information about the hotspot-runtime-dev mailing list