RFR: 8235257: Split 'assert(loader != NULL && oopDesc::is_oop(loader), "loader must be oop")'

[Stefan Karlsson]

Hi Dan,

On 2019-12-03 15:40, Daniel D. Daugherty wrote:
> src/hotspot/share/classfile/javaClasses.cpp
>      Another possibility is:
> 
>        assert(loader != NULL && oopDesc::is_oop(loader), "loader=" 
> INTPTR_FORMAT " must be oop", p2i(loader));
> 

Right.

>      However, I'm also good with what you have.
> 

OK. Then I'll stick with what I have.

> 
> Thumbs up. I agree that this is trivial.

Thanks for the review.

StefanK

> 
> Dan
> 
> 
> On 12/3/19 9:32 AM, Stefan Karlsson wrote:
>> Hi all,
>>
>> Please review this trivial patch to split this assert into two asserts.
>>
>> https://cr.openjdk.java.net/~stefank/8235257/webrev.01/
>> https://bugs.openjdk.java.net/browse/JDK-8235257
>>
>> We keep hitting this assert in testing and it's unclear if the loader 
>> is NULL or if it is a bad oop. I propose that we split it in two.
>>
>> Thanks,
>> StefanK
>