RFR(xs): 8225219: [TESTBUG] AppCDS tests timed out with -Xcomp and --limit-modules option won't work with Graal

[Vladimir Kozlov]

CCing Igor I. who asked me in the past to add WhiteBoxPermission.
The rest looks good to me.

Vladimir

On 12/4/19 1:06 PM, Calvin Cheung wrote:
> Hi Vladimir,
> 
> Thanks for your review!
> 
> On 12/4/19 11:36 AM, Vladimir Kozlov wrote:
>> I think you need also install WhiteBoxPermission:
>>
>>  * @run driver ClassFileInstaller sun.hotspot.WhiteBox sun.hotspot.WhiteBox$WhiteBoxPermission
> Actually, the test runs fine without the WhiteBoxPermission. I know that some tests include it but I'm not sure why.
>>
>> an you don't need import WB if you not using its classes:
>>
>> import sun.hotspot.WhiteBox;
> 
> You're right. I've removed it in the updated webrev:
> 
>      http://cr.openjdk.java.net/~ccheung/8225219/webrev.01/
> 
> thanks,
> 
> Calvin
> 
>>
>> Thanks,
>> Vladimir
>>
>> On 12/4/19 10:20 AM, Calvin Cheung wrote:
>>> bug: https://bugs.openjdk.java.net/browse/JDK-8225219
>>>
>>> webrev: http://cr.openjdk.java.net/~ccheung/8225219/webrev.00/
>>>
>>> This change includes:
>>>
>>> 1. increase the timeout value so that the tests won't timeout with the -Xcomp option;
>>>
>>> 2. exclude the test scenarios which use the --limit-modules option from running if Graal is enabled.
>>>
>>> Tested locally on linux-x64 and passed tier1/2.
>>>
>>> thanks,
>>>
>>> Calvin
>>>
>>>