RFR 8235515: TestBasicLogOutput.java crashes due to EXCEPTION_ACCESS_VIOLATION in HandshakeThreadsOperation::do_handshake

[Patricio Chilano]

Hi Dan,

On 12/10/19 12:43 PM, Daniel D. Daugherty wrote:
> On 12/10/19 10:06 AM, Patricio Chilano wrote:
>> Hi,
>>
>> Could you review this small fix? Signaling the _done semaphore has to 
>> be done after logging, otherwise we could be accessing an already 
>> destroyed HandshakeThreadsOperation object when executing name().
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8235515
>> Webrev: http://cr.openjdk.java.net/~pchilanomate/8235515/v01/webrev/
>
> src/hotspot/share/runtime/handshake.cpp
>     No comments.
>
> Nice catch! Looks like that "name()" call in the logging message
> is the culprit here.
>
> Thumbs up. I think this qualifies as a trivial fix.
Thanks for reviewing it!

Patricio
> Dan
>
>
>
>>
>> Thanks!
>> Patricio
>