RFR: 8235654: JFR leak profiler should not trace through the StringTable

erik.osterlund at oracle.com erik.osterlund at oracle.com
Wed Dec 11 16:32:04 UTC 2019


Hi Coleen,

Thanks for the review!

/Erik

On 12/10/19 5:49 PM, coleen.phillimore at oracle.com wrote:
> Excellent! Thank you!  I think this should be considered trivial if 
> you've run the jfr tests.
> Coleen
>
> On 12/10/19 11:22 AM, erik.osterlund at oracle.com wrote:
>> Hi,
>>
>> The JFR leak profiler finds strong reference chains to object 
>> samples. Weirdly enough, it walks the StringTable roots. But these 
>> oops are phantomly reachable. So they should arguably be excluded 
>> from the root snapshot.This incorrect use of StringTable::oops_do is 
>> the only use of StringTable::oops_do, so I'm removing that function.
>>
>> Bug:
>> https://bugs.openjdk.java.net/browse/JDK-8235654
>>
>> Webrev:
>> http://cr.openjdk.java.net/~eosterlund/8235654/webrev.00/
>>
>> Thanks,
>> /Erik
>



More information about the hotspot-runtime-dev mailing list