RFR[tedious] - 8236028 [TESTBUG] Remove dependency of sun.tools.jar from appcds/JarBuilder

Calvin Cheung calvin.cheung at oracle.com
Tue Dec 17 00:22:50 UTC 2019


On 12/16/19 2:29 PM, Ioi Lam wrote:
> https://bugs.openjdk.java.net/browse/JDK-8236028
> http://cr.openjdk.java.net/~iklam/jdk15/8236028-appcds-JarBuilder-remove-sun-tools-jar.v01/ 
>
>
> About 100 files are changed, but only JarBuilder.java has the 
> important changes
>    - replace com.sun.tools.Main() with ToolProvider.findFirst("jar")
JarBuilder changes look good.
>
> For all the other files, "@modules jdk.jartool/sun.tools.jar" was removed
> using a script.

I did a sanity check on the number of *.java files from the 
test/hotspot/jtreg/runtime/cds dir with the above string and the number 
agrees with your webrev.

thanks,

Calvin

>
> I am running tests with hs-tier1/2.
>
> Thanks
> - Ioi


More information about the hotspot-runtime-dev mailing list