RFR(S) 8233826 Change CDS dumping tty->print_cr() to unified logging

[David Holmes]

Hi Ioi,

On 18/12/2019 4:31 pm, Ioi Lam wrote:
> https://bugs.openjdk.java.net/browse/JDK-8233826
> http://cr.openjdk.java.net/~iklam/jdk15/8233826-cds-change-tty-to-ul.v01/
> 
> During CDS dumping, a few messages are printed out unconditionally
> using tty->print_cr(). This patch changes the message to use
> log_info(cds) instead.

Is there a specific reason you thought dumping needs to be a silent 
operation by default? I kind of liked the fact -Xshare:dump told me what 
it was doing.

There are a couple of cases listed in the bug report that are not in the 
webrev - are they not part of CDS dumping?

Mechanically the changes seem fine.

Thanks,
David
-----

> Some test cases were expecting the messages in stdout. I modified
> these tests to explicitly pass -Xlog:cds.
> 
> Thanks
> - Ioi
>