RFR(s): 8218145: block_if_requested is not proper inlined due to size

[Gerard Ziemski]

Looks good.

> On Feb 1, 2019, at 12:19 PM, Robbin Ehn <robbin.ehn at oracle.com> wrote:
> 
> Hi, here is v2.
> 
> http://cr.openjdk.java.net/~rehn/8218145/2/inc/
> http://cr.openjdk.java.net/~rehn/8218145/2/
> 
> /Robbin
> 
> On 2019-02-01 10:54, Robbin Ehn wrote:
>> Hi all, please review.
>> Code:
>> http://cr.openjdk.java.net/~rehn/8218145/webrev/index.html
>> Issue:
>> https://bugs.openjdk.java.net/browse/JDK-8218145
>> SafepointMechanism::block_if_requested(JavaThread*) is often not inlined to due inline-unit-growth.
>> This improve the inlining frequency with 6-7x.
>> Some startup benchmarks show 1% better time.
>> Test -+ThreadsLocalHandshakes and t1.
>> Note that we are planning to deprecate -ThreadsLocalHandshakes in 13, therefore -ThreadsLocalHandshakes is put in slow path to further reduce size.
>> When we can remove the uses_thread_local_poll() it become so small it is always inlined. Arguably this method should have ALWAYSINLINE, but I would prefer not.
>> Thanks, Robbin