RFR(S) JDK-8218004: Clean up terminology for shared methods within the JVM for indy and condy support

[coleen.phillimore at oracle.com]

This looks good especially:

http://cr.openjdk.java.net/~lfoltan/bug_jdk8218004.1/webrev/src/hotspot/share/utilities/constantTag.hpp.udiff.html

We always miss the InError case.
Thanks,
Coleen

On 2/4/19 7:20 PM, Lois Foltan wrote:
> Please review this change to remove "invoke_dynamic" from the name of 
> several ConstantPool bootstrap helper methods that are shared by both 
> indy and condy.
>
> open webrev at: 
> http://cr.openjdk.java.net/~lfoltan/bug_jdk8218004.1/webrev/
> bug link: https://bugs.openjdk.java.net/browse/JDK-8218004
> co-contributors: Lois Foltan & John Rose
>
> Testing: hs-tier1-4 & jdk-tier1-3 (all platforms - in progress), 
> hs-tier5-6 (linux only - in progress), JCK vm & lang (linux only - 
> completed)
>
> Thanks,
> Lois