RFR(XXS) 8218558: NMT stack traces in output should show mt component for virtual memory allocations

Aleksey Shipilev shade at redhat.com
Wed Feb 6 15:47:25 UTC 2019


On 2/6/19 4:23 PM, zgu at redhat.com wrote:
> Please review this small enhancement that outputs memory types for
> virtual memory allocations [1]. This mirrors JDK-8139673, which outputs
> memory types for malloc allocations.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8218558
> Webrev: http://cr.openjdk.java.net/~zgu/JDK-8218558/webrev.00/

Looks okay to me.

Minor nit:

 *) Excess space at L73 here:

  71 class VirtualMemoryAllocationSite : public AllocationSite<VirtualMemory> {
  72 private:
  73   MEMFLAGS  _flag;

-Aleksey



More information about the hotspot-runtime-dev mailing list