RFR (S) 8167548: [TESTBUG] Logging tests put log files in source tree
David Holmes
david.holmes at oracle.com
Fri Feb 8 00:26:07 UTC 2019
Hi Harold,
On 8/02/2019 10:08 am, Harold Seigel wrote:
> Hi,
>
> Please review this fix for JDK-8167548. The test used the wrong
> 'predictable' file names so the files were not getting deleted.
I'm confused. Where does the magic "1969-12-31_19-00-00" date string
come from?
Second, this still means the test puts logs into the source tree, which
is a bad thing. can we not fix this so that the log file is in a tmp
directory, or a jtreg working directory or ...?
Thanks,
David
> Open Webrev:
> http://cr.openjdk.java.net/~hseigel/bug_8167548/webrev/index.html
>
> JBS Bug: https://bugs.openjdk.java.net/browse/JDK-8167548
>
> The fix was tested by hand on Linux x64 to make sure the files were
> deleted. It was also regression tested on Windows, Solaris, and Mac.
>
> Thanks, Harold
>
More information about the hotspot-runtime-dev
mailing list