RFR: 8218738: Remove dead code in Symbol and friends

[coleen.phillimore at oracle.com]

http://cr.openjdk.java.net/~redestad/8218738/open.01/src/hotspot/share/utilities/utf8.cpp.udiff.html

Nit, can you add // PRODUCT to the #endif ?

Looks good to me.

thanks,
Coleen

On 2/12/19 11:00 AM, Claes Redestad wrote:
>
>
> On 2019-02-12 15:26, coleen.phillimore at oracle.com wrote:
>>> The
>>> alternative to removing in my mind then becomes wrapping unused code in
>>> #ifndef PRODUCT.
>>
>> This is a good idea, with a short comment that it might be useful for 
>> testing.  I'd hate to have to rewrite or resurrect from_quoted_ascii. 
>> Maybe we can move it to a gtest in the future.
>
> Sure, how about this:
> http://cr.openjdk.java.net/~redestad/8218738/open.01/
>
> /Claes