RFR(xs): 8183004: Remove code related to gtest death tests from assert macro

Thomas Stüfe thomas.stuefe at gmail.com
Tue Feb 12 21:18:49 UTC 2019


On Tue, Feb 12, 2019 at 10:09 PM Aleksey Shipilev <shade at redhat.com> wrote:

> On 2/12/19 9:58 PM, Thomas Stüfe wrote:
> > Bug: https://bugs.openjdk.java.net/browse/JDK-8183004
> > cr:
> >
> http://cr.openjdk.java.net/~stuefe/webrevs/8183004--remove-code-related-to-gtest-death-tests-from-assert-macro/webrev.00/webrev/
>
> I like it. I like smaller binaries a lot too.
>
> Was the prefix string "assert failed: " meaningful? Is there a reason to
> remove it?
>
>
Hmm, none really, apart from that is was not really needed to make the test
work. I can re-add it if you prefer.

..Thomas


> -Aleksey
>
>


More information about the hotspot-runtime-dev mailing list