RFR (S) 8218755: [REDO] Symbol leak in prepend_host_package_name
coleen.phillimore at oracle.com
coleen.phillimore at oracle.com
Tue Feb 12 22:23:52 UTC 2019
On 2/12/19 5:21 PM, Kim Barrett wrote:
>> On Feb 12, 2019, at 10:13 AM, coleen.phillimore at oracle.com wrote:
>>
>> Summary: fix Symbol refcounting again, add comment and a test.
>>
>> open webrev at http://cr.openjdk.java.net/~coleenp/2019/8218755.01/webrev
>> bug link https://bugs.openjdk.java.net/browse/JDK-8218755
>>
>> I hope this is better. Ran hs-tier1-6 and a new test!
>>
>> Thanks,
>> Coleen
> So this isn't really a "REDO", but rather a fix on top of the earlier
> "fix", with no "BACKOUT" of that earlier fix. Right?
True. I will take out [REDO] and change to Fix again:
>
> Given that the recently added update_class_name now seems to have only
> one caller, is it really worth keeping?
I asked myself this. I think so because there's commentary that would
distract in the place where it's called.
>
> Other than that, looks good. Thanks for adding a test.
>
Thank you for reviewing and finding the original bug(s)!
Coleen
More information about the hotspot-runtime-dev
mailing list