RFR: 8204551: Event descriptions are truncated in logs

coleen.phillimore at oracle.com coleen.phillimore at oracle.com
Thu Feb 14 16:47:53 UTC 2019


Hi, I should have looked at this before sending out my change.

http://cr.openjdk.java.net/~ysuenaga/JDK-8204551/webrev.02/src/hotspot/share/utilities/events.hpp.udiff.html

Instead of TemplatedStringLogMessage can you name it 
FormatStringLogMessage and FormatStringEventLog?

Otherwise I think this looks fine.  I tried to test it on Windows but 
mach5 lost my hs_err_pid file.   The logging looks fine on Linux.

Thanks,
Coleen

On 2/13/19 11:19 PM, Yasumasa Suenaga wrote:
> Hi,
>
> I posted the issue that some log messages in hs_err and VM.info are truncated.
>
>    https://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2018-June/028410.html
>
> I've had some discussion about it on JBS, and I uploaded webrev for it.
> I use THIS_FILE macro for internal exceptions, and I expanded to 512 bytes
> for capacity of internal exception.
> It has passed submit repo tests. Could you review it?
>
>    JBS: https://bugs.openjdk.java.net/browse/JDK-8204551
>    webrev: http://cr.openjdk.java.net/~ysuenaga/JDK-8204551/webrev.02/
>
>
> Thanks,
>
> Yasumasa



More information about the hotspot-runtime-dev mailing list