RFR (XS) 8216049: stringTable::intern creates redundant String when looking up existing one

Robbin Ehn robbin.ehn at oracle.com
Fri Feb 15 19:41:45 UTC 2019


On 2019-02-15 20:20, Aleksey Shipilev wrote:
> RFE:
>   https://bugs.openjdk.java.net/browse/JDK-8216049
> 
> Fix:
>   http://cr.openjdk.java.net/~shade/8216049/webrev.01/
> 
> This is the fix for performance regression in 11 that shows up in stack trace generation benchmarks.
> See bug and linked issues for more info. The original patch is suggested by Claes. I have been
> looking how to improve it, but eventually backed off any improvements on top of it. The simplicity
> of this patch plays well with future backports to 12u and 11u to fix the performance regression there.

I also had another solution in mind but as you point out the complexity increases fast.

Ship it!

/Robbin

> 
> Testing: tier1, benchmarks, jdk-submit
> 
> Thanks,
> -Aleksey
> 


More information about the hotspot-runtime-dev mailing list