RFR(XXS): 8219441: test_logMessageTest missing static storage

[Aleksey Shipilev]

On 2/20/19 11:55 AM, Robbin Ehn wrote:
> Thanks, Robbin
> 
> diff -r 54a3ecb5a39b test/hotspot/gtest/logging/test_logMessageTest.cpp
> --- a/test/hotspot/gtest/logging/test_logMessageTest.cpp    Wed Feb 20 09:41:00 2019 +0100
> +++ b/test/hotspot/gtest/logging/test_logMessageTest.cpp    Wed Feb 20 11:44:47 2019 +0100
> @@ -34,16 +34,18 @@
>  class LogMessageTest : public LogTestFixture {
>  protected:
>    static Log(logging) _log;
>    static const char* _level_filename[];
>    LogMessageTest();
>    ~LogMessageTest();
>  };
> 
> +Log(logging) LogMessageTest::_log;
> +
>  const char* LogMessageTest::_level_filename[] = {
>    NULL, // LogLevel::Off
>  #define LOG_LEVEL(name, printname) "multiline-" #printname ".log",
>    LOG_LEVEL_LIST
>  #undef LOG_LEVEL
>  };
> 
>  LogMessageTest::LogMessageTest() {

Looks good and trivial to me.

-Aleksey,
whistling "Log-log-loggin' on heaven's door".