RFR (XS): 8217765: Internal Error (javaCalls.cpp:61) guarantee(thread->can_call_java()) failed

[David Holmes]

Hi Claes,

Thanks for looking at this.

On 20/02/2019 9:06 pm, Claes Redestad wrote:
> Hi,
> 
> On 2019-02-20 01:53, David Holmes wrote:
>> webrev: http://cr.openjdk.java.net/~dholmes/8217765/webrev.13/
> 
> +          if (log_is_enabled(Trace, class, nestmates)) {
> +            ResourceMark rm(THREAD);
> +            log_trace(class, nestmates)("- validation required 
> resolution in an unsuitable thread");
> +          }
> 
> The ResourceMark seems superfluous, so I think this should be
> simplified to just the unguarded log_trace statement.

You're absolutely right. I copied the entire chunk of code and edited 
the message without thinking about the details.

I will fix before pushing. (I'll wait a while longer for any other 
comments.)

> Otherwise looks good.

Thanks,
David
-----

> /Claes