RFR(S): 8214777: Avoid some GCC 8.X strncpy() errors in HotSpot

Mikael Vidstedt mikael.vidstedt at oracle.com
Fri Feb 22 18:38:06 UTC 2019


Robbin, Kim - thanks for the reviews! Change pushed.

Cheers,
Mikael

> On Feb 21, 2019, at 12:01 PM, Kim Barrett <kim.barrett at oracle.com> wrote:
> 
>> On Feb 20, 2019, at 10:08 PM, Mikael Vidstedt <mikael.vidstedt at oracle.com> wrote:
>> 
>> 
>>> On Feb 20, 2019, at 4:34 PM, Kim Barrett <kim.barrett at oracle.com> wrote:
>>> I think these should all be using os::strdup_check_oom:
>>> 
>>> src/hotspot/os/aix/os_perf_aix.cpp
>>> src/hotspot/os/linux/os_perf_linux.cpp
>>> src/hotspot/os/solaris/os_perf_solaris.cpp
>>> src/hotspot/os/windows/os_perf_windows.cpp
>> 
>> 
>> Fully agree. How about this:
>> 
>> webrev (full): http://cr.openjdk.java.net/~mikael/webrevs/8214777/webrev.01/open/webrev/
>> webrev (incremental): http://cr.openjdk.java.net/~mikael/webrevs/8214777/webrev.01.incr/open/webrev/
> 
> Looks good.
> 



More information about the hotspot-runtime-dev mailing list