RFR (XS) 8219583: Windows build failure after JDK-8214777 (Avoid some GCC 8.X strncpy() errors in HotSpot)

[Aleksey Shipilev]

On 2/22/19 8:56 PM, Kim Barrett wrote:
>> New code introduced in JDK-8214777 calls to "naked" snprintf, which fails to compile in my Windows
>> configs. It seems to be the omen to replace these with the usual jio_snprintf calls. There is also
>> os::snprintf we can use instead, but shared runtime code really likes jio_snprintf, and it will
>> delegate as needed.
> 
> Please use os::snprintf: https://bugs.openjdk.java.net/browse/JDK-8198918

Even if the same file (and other files in those components) use jio_snprintf, right? I did the first
patch with os::snprintf, but reverted it on stylistic grounds. No validation with -Wformat sounds
ominous, though.

-Aleksey