RFR (trivial): 8219893: Compile warning: "Unconfigured platform" in jfrBigEndian.hpp on MIPS

Jie Fu fujie at loongson.cn
Thu Feb 28 03:47:45 UTC 2019


Hi all,

Bug: https://bugs.openjdk.java.net/browse/JDK-8219893

A compile warning occurs while compile HotSpot VM on MIPS.
---------------------------------------------
/home/loongson/fujie/jdk/src/hotspot/share/jfr/utilities/jfrBigEndian.hpp:108:4: 
warning: #warning "Unconfigured platform" [-Wcpp]
    #warning "Unconfigured platform"
     ^
---------------------------------------------


This can be fixed by
---------------------------------------------
diff -r 8e069f7b4fab src/hotspot/share/jfr/utilities/jfrBigEndian.hpp
--- a/src/hotspot/share/jfr/utilities/jfrBigEndian.hpp  Wed Feb 27 
12:19:29 2019 -0800
+++ b/src/hotspot/share/jfr/utilities/jfrBigEndian.hpp  Thu Feb 28 
11:05:38 2019 +0800
@@ -102,7 +102,7 @@
  inline bool JfrBigEndian::platform_supports_unaligned_reads(void) {
  #if defined(IA32) || defined(AMD64) || defined(PPC) || defined(S390)
    return true;
-#elif defined(SPARC) || defined(ARM) || defined(AARCH64)
+#elif defined(SPARC) || defined(ARM) || defined(AARCH64) || defined(MIPS)
    return false;
  #else
    #warning "Unconfigured platform"
---------------------------------------------


The change has been tested on Linux/x64 and Loongson's Linux/mips64-port.

Could you please review it?
Thanks a lot.

Best regards,
Jie




More information about the hotspot-runtime-dev mailing list