RFR 8219579: Remove redundant signature parsing from the verifier

Harold Seigel harold.seigel at oracle.com
Thu Feb 28 21:25:54 UTC 2019


Thanks Claes!

Harold

On 2/28/2019 4:06 PM, Claes Redestad wrote:
> Hi Harold,
>
> looks great! Thanks.
>
> /Claes
>
> On 2019-02-28 21:57, Harold Seigel wrote:
>> Hi,
>>
>> Please review this fix to remove redundant field and method signature 
>> parsing from the verifier.  The parsing is redundant because field 
>> and method signatures are already checked by ClassFileParser.
>>
>> Note that current behavior, in the odd case where a user enables 
>> local verification but disables remote verification, is that both 
>> local and remote classes get verified.  The change in arguments.cpp 
>> does not change that.
>>
>> Open Webrev: 
>> http://cr.openjdk.java.net/~hseigel/bug_8219579/webrev/index.html
>>
>> JBS Bug:  https://bugs.openjdk.java.net/browse/JDK-8219579
>>
>> The fix was regression tested by running Mach5 tiers 1 and 2 tests 
>> and builds on Linux-x64, Solaris, Windows, and Mac OS X, running 
>> tiers 3-5 tests on Linux-x64, and by running JCK-13 Lang and VM tests 
>> on Linux-x64.
>>
>> Thanks, Harold
>>


More information about the hotspot-runtime-dev mailing list