RFR 8215644: Clean up globalDefinitions_<compiler>.hpp

[Kim Barrett]

> On Jan 2, 2019, at 1:49 PM, Harold David Seigel <harold.seigel at oracle.com> wrote:
> 
> Hi Kim,
> 
> Thanks for looking at this.
> 
> Please review this updated webrev:
> 
>         http://cr.openjdk.java.net/~hseigel/bug_8215644.2/webrev/index.html
> 
> The only difference from the previous webrev is between lines 1100 - 1110 in the modified globalDefinitions.hpp file.  The change includes removing the two-arg build_u2_from() function as suggested below.
> 
> I also created a new RFE, JDK-8216010, to change the callers of build_u2_from() and remove it.

The comments on lines 1103-6 are kind of broken, since there aren’t any four byte => 32-bit word
functions here anymore.  Of course, fixing JDK-8216010 will delete these comments anyway.
So I’m not too worried about it if that new RFE is going to be fixed soon.

Looks good.  I don’t need a new webrev if you decide to fix the comment.