RFR(XS): 8216269: [s390] Debug build broken because CodeBlob has not been declared

[Aleksey Shipilev]

On 1/7/19 3:19 PM, Doerr, Martin wrote:
> In file included from .../jdk/src/hotspot/share/code/relocInfo.hpp:427:0,
> .../jdk/src/hotspot/cpu/s390/relocInfo_s390.hpp:119:78: error: 'CodeBlob' has not been declared
>    static bool update_oop_pool(address begin, address end, address newTarget, CodeBlob* cb);
>                                                                               ^~~~~~~~
> 
> Please review this tiny fix:
> http://cr.openjdk.java.net/~mdoerr/8216269_s390_fix_build/webrev.00/

Oh. I have just been looking into that in JDK-8216272, closed that as duplicate. Checked the your
patch fixed the build failure for me. I tried to put the missing forward declaration into
src/hotspot/cpu/s390/relocInfo_s390.hpp, closer to the actual declaration that uses CodeBlob, but
then other compilation units look for in in relocInfo.hpp itself.

I don't think we need a comment, and also added line should not break the alphabetic order?

 class nmethod;
+class CodeBlob;
 class CompiledMethod;
 class Metadata;
 class NativeMovConstReg;

Otherwise this looks good and trivial.

-Aleksey