RFR(XS): 8216269: [s390] Debug build broken because CodeBlob has not been declared

[Doerr, Martin]

Hi Coleen and Aleksey,

thank you for the reviews.
I'll push Aleksey's version tomorrow.

Best regards,
Martin


-----Original Message-----
From: hotspot-runtime-dev <hotspot-runtime-dev-bounces at openjdk.java.net> On Behalf Of coleen.phillimore at oracle.com
Sent: Montag, 7. Januar 2019 15:41
To: hotspot-runtime-dev at openjdk.java.net
Subject: Re: RFR(XS): 8216269: [s390] Debug build broken because CodeBlob has not been declared



On 1/7/19 9:36 AM, Aleksey Shipilev wrote:
> On 1/7/19 3:19 PM, Doerr, Martin wrote:
>> In file included from .../jdk/src/hotspot/share/code/relocInfo.hpp:427:0,
>> .../jdk/src/hotspot/cpu/s390/relocInfo_s390.hpp:119:78: error: 'CodeBlob' has not been declared
>>     static bool update_oop_pool(address begin, address end, address newTarget, CodeBlob* cb);
>>                                                                                ^~~~~~~~
>>
>> Please review this tiny fix:
>> http://cr.openjdk.java.net/~mdoerr/8216269_s390_fix_build/webrev.00/
> Oh. I have just been looking into that in JDK-8216272, closed that as duplicate. Checked the your
> patch fixed the build failure for me. I tried to put the missing forward declaration into
> src/hotspot/cpu/s390/relocInfo_s390.hpp, closer to the actual declaration that uses CodeBlob, but
> then other compilation units look for in in relocInfo.hpp itself.
>
> I don't think we need a comment, and also added line should not break the alphabetic order?

I didn't know if we had that guideline for forward declarations, but 
sometimes try to respect it when the files are from a similar subsystem.

Looks good/trivial to me as well.

thanks,
Coleen
>
>   class nmethod;
> +class CodeBlob;
>   class CompiledMethod;
>   class Metadata;
>   class NativeMovConstReg;
>
> Otherwise this looks good and trivial.
>
> -Aleksey
>
>