RFR 8215901: [TESTBUG] TestCheckedEnsureLocalCapacity.java fails intermittently

Harold David Seigel harold.seigel at oracle.com
Tue Jan 8 16:25:48 UTC 2019


Hi Dan,

Please review this updated webrev that removes the '^' from 
'^WARNING:'.  I also removed the trailing blank.

    http://cr.openjdk.java.net/~hseigel/bug_8215901.2/webrev/index.html

Thanks, Harold

On 1/8/2019 9:41 AM, Daniel D. Daugherty wrote:
> Sorry, I just took another look at the test:
>
> This line is also a problem:
>
>   L3:     private static final String WARNING = "^WARNING: ";
>
> Because of the '^' anchor, you could miss an unexpected "WARNING: " in
> the "no warnings" test case.
>
> Dan
>
>
> On 1/8/19 9:38 AM, Harold David Seigel wrote:
>> Thanks Dan!
>>
>> I'll add the comment before pushing.
>>
>> Harold
>>
>> On 1/8/2019 9:36 AM, Daniel D. Daugherty wrote:
>>> On 1/8/19 9:27 AM, Harold David Seigel wrote:
>>>> Hi,
>>>>
>>>> Please review this small fix for JDK-8215901.  The test passes if 
>>>> its output matches a certain pattern.  The fix, suggested by Dan, 
>>>> changes the pattern to not require it to be at the beginning of a 
>>>> line.
>>>>
>>>> Open Webrev: http://cr.openjdk.java.net/~hseigel/bug_8215901/webrev/
>>>
>>> test/hotspot/jtreg/runtime/jni/checked/TestCheckedEnsureLocalCapacity.java 
>>>
>>>     Perhaps a comment above the variable:
>>>
>>>     // Not anchored to the beginning of the line to allow match with 
>>> interleaved output.
>>>
>>> Thumbs up. Your call on whether to add the comment or something like 
>>> it.
>>> Don't need to see another webrev.
>>>
>>> Dan
>>>
>>>
>>>>
>>>> JBS Bug:  https://bugs.openjdk.java.net/browse/JDK-8215901
>>>>
>>>> The fix was tested by running the test over 600 times on multiple 
>>>> platforms.
>>>>
>>>> Thanks, Harold
>>>>
>>>
>


More information about the hotspot-runtime-dev mailing list