RFR(XS): 8216560: gtest build broken on PPC64

Doerr, Martin martin.doerr at sap.com
Mon Jan 14 08:34:35 UTC 2019


Hi Aleksey,

done. Thanks for the review.

Best regards,
Martin


-----Original Message-----
From: Aleksey Shipilev <shade at redhat.com> 
Sent: Samstag, 12. Januar 2019 14:04
To: Doerr, Martin <martin.doerr at sap.com>; hotspot-runtime-dev at openjdk.java.net
Subject: Re: RFR(XS): 8216560: gtest build broken on PPC64

On 1/11/19 3:22 PM, Doerr, Martin wrote:
> "set_thread_state" is in thread.inline.hpp on PPC64 and aarch64. So aarch64 seems to be affected as
> well (not checked).

Right. AArch64 is also broken. I submitted this:
  https://bugs.openjdk.java.net/browse/JDK-8216591

...but see that your fix also handles that build failure. Closed as duplicate.

> Webrev:
> http://cr.openjdk.java.net/~mdoerr/8216560_fix_gtest_build/webrev.00/

Looks good!

You might want to fix the synopsis to mention both PPC64 and AArch64.

-Aleksey



More information about the hotspot-runtime-dev mailing list