RFR: 8217325: Enable inlining of java_lang_Class::oop_size_raw

coleen.phillimore at oracle.com coleen.phillimore at oracle.com
Thu Jan 17 19:24:33 UTC 2019


+1 nice!
Coleen

On 1/17/19 12:23 PM, Aleksey Shipilev wrote:
> On 1/17/19 6:12 PM, Claes Redestad wrote:
>> Hi,
>>
>> InstanceMirrorKlass::oop_size could be helped slightly if
>> java_lang_Class::oop_size_raw was made inlineable.
>>
>> This significantly speeds up one branch in oopDesc::size_given_klass
>> (heavily used by G1, at least during startup/warmup) while not causing
>> any increase in binary size (linux x64).
>>
>> Bug:    https://bugs.openjdk.java.net/browse/JDK-8217325
>> Webrev: http://cr.openjdk.java.net/~redestad/8217325/open.00/
> Looks good.
>
> I remember seeing the profiles for Shenandoah that walks the objects and uses oopDesc::size*
> heavily, and it was inlined in product builds. That said, inlining it manually does not hurt.
>
> -Aleksey
>



More information about the hotspot-runtime-dev mailing list