RFR: 8217450: Add PackageEntry::locked_lookup_only

Claes Redestad claes.redestad at oracle.com
Tue Jan 22 10:53:30 UTC 2019


On 2019-01-22 01:02, David Holmes wrote:
> Looks good.

Thanks!

> Please update copyright years.

Done.

> 
> One minor suggestions:
> 
> src/hotspot/share/classfile/packageEntry.hpp
> 
> The new method seems out of order where it is declared. I think it would 
> be better to follow lookup_only with locked_lookup_only and also clarify 
> the locking e.g.
> 
>      // Only lookup Package within loader's package entry table.
> +   // This will acquire the Module_lock.
>      PackageEntry* lookup_only(Symbol* Package);
> +
> +   // Only lookup Package within loader's package entry table.
> +   // This assumes the Module_lock is already held.
> +   PackageEntry* locked_lookup_only(Symbol* Package);

Sure, updated in-place:

http://cr.openjdk.java.net/~redestad/8217450/open.00/

/Claes


More information about the hotspot-runtime-dev mailing list