RFR(t) 8217424 Remove the idempotent parameter to Method::sort_methods

[Aleksey Shipilev]

On 1/22/19 6:30 AM, Ioi Lam wrote:
> https://bugs.openjdk.java.net/browse/JDK-8217424
> http://cr.openjdk.java.net/~iklam/jdk13/8217424-sort-methods-idempotent-param.v01/

This looks fine. It is not as obvious/trivial, given there are default arguments that can be
partially used somewhere (for example, Method::sort_methods(total, true)), but there seem to be only
two uses of Method::sort_methods now:

  // Sort method array by ascending method name (for faster lookups & vtable construction)
  // Note that the ordering is not alphabetical, see Symbol::fast_compare
  Method::sort_methods(methods);

...and:

  Method::sort_methods(total_default_methods, false, false);

...neither of which does anything fancy, so this makes the change okay.

-Aleksey