RFR: 8217450: Add PackageEntry::locked_lookup_only

Aleksey Shipilev shade at redhat.com
Tue Jan 22 15:11:31 UTC 2019


On 1/22/19 2:27 PM, Claes Redestad wrote:
> Might as well remove PackageEntry* pkg and simplify:
> 
> 211        package_table->locked_create_entry_or_null(pkg_list->at(x),
> ModuleEntryTable::javabase_moduleEntry());
> 212        assert(package_table->locked_lookup_only(pkg_list->at(x)) != NULL,
> 213               "Unable to create a " JAVA_BASE_NAME " package entry");

Mmm. Compilers might complain we do not use the returned value? I think the previous way made a bit
more sense, and was a bit faster. Just move the local variable declaration?

> http://cr.openjdk.java.net/~redestad/8217450/open.01/

Looks good.

-Aleksey



More information about the hotspot-runtime-dev mailing list