RFR (S) 8216493: VirtualSpaceNodeTest.half_vsn_is_committed_humongous_chunk_is_used_test_vm crashes on local machine

[Gerard Ziemski]

Hi all,

Please review this small gtest fix, which fixes “VirtualSpaceNodeTest.half_vsn_is_committed_humongous_chunk_is_used_test_vm” that used to crash for me locally on both Mac and Linux.

The main idea behind this fix is to redo "ChunkManagerRestorer", so that it is more robust in restoring the pre-existing chunks. I’m not sure how it worked before, as to me, it seems that the only case it can currently work, is in a situation where there are no pre-existing chunks. The new implementation uses std::vector to keep track of chunks that need to be restored, which makes it independent of how the underlying chunk list manipulates its contents.

References:

https://bugs.openjdk.java.net/browse/JDK-8216493
http://cr.openjdk.java.net/~gziemski/8216493_rev1

Passes locally when run on Mac and Linux (used to crash), passes Mach5 hs-tier1,2,3, additional Mach5 hs-tier1,2,3,4,5,6 testing in progress…


Cheers