RFR (S) 8216493: VirtualSpaceNodeTest.half_vsn_is_committed_humongous_chunk_is_used_test_vm crashes on local machine

[Gerard Ziemski]

Thank you Igor!

> On Jan 23, 2019, at 1:33 PM, Igor Ignatyev <igor.ignatyev at oracle.com> wrote:
> 
> Hi Gerard,
> 
> the fix looks reasonable to me, one small editorial nit: include of standard headers should go before custom headers, so could you please move 'include <vector>' to L#25 (as precompiled.hpp still must be 1st include).

Will do.


> 
> PS I don't think you need to run 1-6 tiers to test this change, as the vast majority of the testing in these tiers do not include gtest tests.

I had no idea which tier this test was in, so I just thought it would be safe to do 1-6 tiers.


cheers

> 
> Thanks,
> -- Igor
> 
>> On Jan 22, 2019, at 9:37 AM, Gerard Ziemski <gerard.ziemski at oracle.com> wrote:
>> 
>> Hi all,
>> 
>> Please review this small gtest fix, which fixes “VirtualSpaceNodeTest.half_vsn_is_committed_humongous_chunk_is_used_test_vm” that used to crash for me locally on both Mac and Linux.
>> 
>> The main idea behind this fix is to redo "ChunkManagerRestorer", so that it is more robust in restoring the pre-existing chunks. I’m not sure how it worked before, as to me, it seems that the only case it can currently work, is in a situation where there are no pre-existing chunks. The new implementation uses std::vector to keep track of chunks that need to be restored, which makes it independent of how the underlying chunk list manipulates its contents.
>> 
>> References:
>> 
>> https://bugs.openjdk.java.net/browse/JDK-8216493
>> http://cr.openjdk.java.net/~gziemski/8216493_rev1
>> 
>> Passes locally when run on Mac and Linux (used to crash), passes Mach5 hs-tier1,2,3, additional Mach5 hs-tier1,2,3,4,5,6 testing in progress…
>> 
>> 
>> Cheers
>> 
>