RFR (S) 8216493: VirtualSpaceNodeTest.half_vsn_is_committed_humongous_chunk_is_used_test_vm crashes on local machine

[Igor Ignatyev]

right,.. I totally forgot about us redefining assert. sure in this case, I'm fine w/ having <vector> the last include. sorry for making you do extra work in vain.
 
-- Igor

> On Jan 24, 2019, at 9:17 AM, Gerard Ziemski <gerard.ziemski at oracle.com> wrote:
> 
> hi Igor,
> 
>> On Jan 23, 2019, at 1:43 PM, Gerard Ziemski <gerard.ziemski at oracle.com> wrote:
>> 
>>> On Jan 23, 2019, at 1:33 PM, Igor Ignatyev <igor.ignatyev at oracle.com> wrote:
>>> 
>>> Hi Gerard,
>>> 
>>> the fix looks reasonable to me, one small editorial nit: include of standard headers should go before custom headers, so could you please move 'include <vector>' to L#25 (as precompiled.hpp still must be 1st include).
>> 
>> Will do.
> 
> I ran into a problem with the “assert” macro, if I move 'include <vector>’ before other hotspot headers.
> 
> <vector> header pulls in an incompatible “assert” macro that breaks our code, ex:
> 
> open/src/hotspot/share/memory/freeList.hpp:69:25: error: too many arguments provided to function-like macro invocation jib > assert(_count >= 0, "Count should not be negative"); jib > ^ jib > #########/devkit-macosx_x64/Xcode9.4-MacOSX10.13+1.0/devkit-macosx_x64-Xcode9.4-MacOSX10.13+1.0.tar.gz/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk/usr/include/assert.h:92:9: note: macro 'assert' defined here jib > #define assert(e)
> 
> Fixing this here is beyond the scope, so I hope you’re OK with <vector> being the last include?
> 
> 
> cheers