RFR(S/M): 8217659 monitor_logging updates from Async Monitor Deflation project

[Daniel D. Daugherty]

Robbin,

Thanks for the review!

David and Coleen, please confirm if I have addressed your comments
from code review round 0. Thanks!

Dan


On 1/28/19 3:55 PM, Robbin Ehn wrote:
> Hi Dan, looks good, thanks.
>
> /Robbin
>
> On 2019-01-27 04:10, Daniel D. Daugherty wrote:
>> Greetings,
>>
>> I've updated the patch to resolve code review comments from David H.
>> and Coleen. I've also rebased the patch to the jdk/jdk repo at the
>> 'jdk-13+5' tag (plus the 8217658 patch); there were no merge surprises.
>>
>> Here's an incremental webrev:
>>
>> http://cr.openjdk.java.net/~dcubed/8217659-webrev/1-for-jdk13.inc/
>>
>> I've also generated a full webrev since the changes to synchronizer.cpp
>> are extensive and that's the easier way to review it:
>>
>> http://cr.openjdk.java.net/~dcubed/8217659-webrev/1-for-jdk13.full/
>>
>> This patch along with 8217658 have been through Mach5
>> builds-tier1,hs-tier1,jdk-tier1,hs-tier2,hs-tier3 testing with
>> no failures.
>>
>> Thanks, in advance, for any questions, comments or suggestions.
>>
>> Dan
>>
>> P.S.
>> I've attached sample output for running Hello.java with the
>> monitorinflation logging enabled at Info, Debug and Trace.
>>
>>
>> On 1/23/19 3:16 PM, Daniel D. Daugherty wrote:
>>> Greetings,
>>>
>>> I have a (S)mall/(M)edium patch extracted from the Async Monitor 
>>> Deflation
>>> project that is ready for code review. I'm calling this a 
>>> (S)mall/(M)edium
>>> because the logic changes are (S)mall, but the logging code is 
>>> tedious and
>>> there's a bunch of it in audit_and_print_stats() so (M)edium.
>>>
>>> The short version of what this patch is about:
>>>
>>>     This sub-task captures updates and additions to the
>>>     baseline monitor logging code.
>>>
>>> The details are in the bug report:
>>>
>>>     JDK-8217659 monitor_logging updates from Async Monitor Deflation 
>>> project
>>>     https://bugs.openjdk.java.net/browse/JDK-8217659
>>>
>>> Here's the webrev:
>>>
>>> http://cr.openjdk.java.net/~dcubed/8217659-webrev/0-for-jdk13/
>>>
>>> This patch along with the other two patches for Async Monitor Deflation
>>> project have been through Mach5 
>>> builds-tier1,hs-tier1,jdk-tier1,hs-tier2,hs-tier3
>>> testing and I'm currently running my stress testing kits on my 
>>> Linux-X64
>>> and Solaris-X64 servers.
>>>
>>> I have been actively using this new logging code while debugging my
>>> port of the Async Monitor Deflation project code.
>>>
>>> Thanks, in advance, for any questions, comments or suggestions.
>>>
>>> Dan
>>>
>>>
>>