RFR(S) 8226406: JVM fails to detect mismatched or corrupt CDS archive

[Jiangli Zhou]

Hi Calvin,

Per our off-mailing-list email exchange from the previous code review
for https://bugs.openjdk.java.net/browse/JDK-8211723, I created
https://bugs.openjdk.java.net/browse/JDK-8227370, 'Remove
SharedPathsMiscInfo'
. I think the crash caused by premature runtime accessing of
_paths_misc_info_size should be handled as part of JDK-8227370, rather
than further patching up the SharedPathsMiscInfo.

Thanks and regards,
Jiangli

On Wed, Jul 3, 2019 at 5:59 PM Calvin Cheung <calvin.cheung at oracle.com> wrote:
>
> bug: https://bugs.openjdk.java.net/browse/JDK-8226406
>
> webrev: http://cr.openjdk.java.net/~ccheung/8226406/webrev.00/
>
> This bug was found during a bootcycle build when a shared archive built
> by a 64-bit JDK version is used by a 32-bit JDK version. It is due to
> some of the important header fields such as the _jvm_ident was not
> checked prior to accessinng other fields such as the _paths_misc_info_size.
>
> This fix involves checking most the fields in CDSFileMapHeaderBase
> before accessing other fields.
>
> Testing: tiers 1-3.
>
> thanks,
>
> Calvin
>